-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 6.0 / Args #164
Conversation
TODO: rewrite all stories in terms of args ;) |
@shilman Looks great 👏 I just realized I don't really know the finer details of how this is supposed to work! Are there any docs or anything I can read to understand how args are meant to work? Thanks for taking the time to do this. |
Thanks @kylesuss ! Docs are still WIP, but here are some resources to help get a sense of what's going on. Questions/suggestions/contributions welcome to make this better on both the code and documentation! |
Thanks @shilman . Sorry I have been a bit distracted trying to wrap some QA. Will take a look at this next week! |
@kylesuss no rush at all. There are still underlying bugs to fix in Storybook before this can even be considered for merge. I only put the PR up to get the ball rolling. Godspeed on the QA! |
@shilman Aside from the comments I made re: documenting |
Is this ready? |
Ready? Not sure but we can merge and iterate if it’s blocking your stuff |
not blocking anything on my part Just wanted to make some progress. |
@shilman @ndelangen is this done now? |
I dunno @shilman ? |
# Conflicts: # yarn.lock
🚀 PR was released in v5.1.0 🚀 |
What I did
Basic
story to all components to showcase SB Argsaddon-deps
temporarily until we can figure out 6.0/args compatStill to do
children
crashes Storybook #10498'